----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127764/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description ------- numerous icon tests expect the actual production plasma theme to be present it won't however be resolved because we disable qstandardpaths' default fallbacks by switching it into testing mode. this ultimately means the test run needs to have XDG_DATA_DIRS in the environment, if it doesn't test data will not be present furthermore QSKIP test that depend on: - hicolor icon theme to be present - production plasma themes this allows the entire test to pass in less than optimal environments by means of skipping but also gives a reasonable hint as to why tests are skipped in the first place. also moving forward if a test isn't guarded we still have the warning about failure potential allowing someone to quickly figure out why things failed Diffs ----- autotests/iconitemtest.cpp 0b55abdf17bc858c100407a10c9aa7b0dbba203e Diff: https://git.reviewboard.kde.org/r/127764/diff/ Testing ------- test passes in minimal environment - skips when xdg_data is not set - doesnt' skip with data set - skips when hicolor is not installed at all - passes when hicolor is installed Thanks, Harald Sitter
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
