broulik added a comment.
Nice INLINE COMMENTS src/maps.h:92 Not too fond of allocating a list just to get an item from it, can we perhaps do something like (m_data.constBegin() + index).value(); src/pulseaudio.h:48 You don't need slots to connect to with the new connect syntax iirc REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1393 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: broulik, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
