davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY We would check if the string (unit1) matched any known units (s) using a case insensitve compare. If it did, we would treat that as a valid unit and pass it on to KUnitConversion, but unfortunately that is case senstive, and then fails to find anything. This fixes the case of the user typed unit to be correct. TEST PLAN Ran krunner with "640 gbp in eur" it now returns the same as "640 GBP in EUR" . debug in kunitconversion shows it now has a valid unit ID for the first query. (the result is still utterly wrong, but it's one problem less) REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D1338 AFFECTED FILES runners/converter/converterrunner.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
