----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127475/#review94035 -----------------------------------------------------------
Thanks! Unless one can really prove that a blocking DBus call is safe, it must be assumed to cause deadlocks. Careless blocking calls are causing us so many problems. - Andreas Hartmetz On March 23, 2016, 3:06 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127475/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 3:06 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Calling kded in a blocking way should be fine, but if we don't do > anything with the result, why wait? > > Also avoids an introspection call. > > CCBUG: 359611 > > > Diffs > ----- > > dataengines/hotplug/hotplugjob.cpp 5c2f93164421af5e6cd5de05b8314288531d121e > > Diff: https://git.reviewboard.kde.org/r/127475/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
