sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land.
I read over it, and as far as I understand what's the problem, your patches look like they make sense. INLINE COMMENTS autotests/client/test_wayland_subsurface.cpp:220 use the function pointer version of QSignalSpy? autotests/client/test_wayland_subsurface.cpp:589 its pending state src/server/surface_interface.cpp:243 that's not a "factor", perhaps just "transformChanged"? src/server/surface_interface.cpp:243 whitespace after && I generally prefer to put parentheses around these right hand sides of the bool assignment, btw. More like a personal preference, which makes it a bit easier to read. REPOSITORY rKWAYLAND KWayland BRANCH subsurface-fixes REVISION DETAIL https://phabricator.kde.org/D1191 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: sebas, plasma-devel, Plasma
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
