graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  There are still a few unrelated changes included and some not-needed includes 
in header files

INLINE COMMENTS
  backends/drm/drm_buffer.h:24 I don't see QPointer used
  backends/drm/drm_output.h:23 either forward declare (see below the forward 
declaration for DrmBackend) or include, not both :-) I assume that forward 
declaration should be sufficient here.
  backends/drm/drm_pointer.h:23 QPointer not used in this file
  backends/drm/scene_qpainter_drm_backend.cpp:54-58 still unrelated

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1168

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to