> On March 15, 2016, 2:32 p.m., Jan Grulich wrote: > > libs/handler.h, line 33 > > <https://git.reviewboard.kde.org/r/127382/diff/1/?file=453109#file453109line33> > > > > Why this include? It doesn't compile with it, I removed it and it > > compiles just fine.
Ooops, thanks - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127382/#review93555 ----------------------------------------------------------- On March 15, 2016, 2:16 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127382/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 2:16 p.m.) > > > Review request for Plasma and Jan Grulich. > > > Repository: plasma-nm > > > Description > ------- > > There are two blocking calls here; the QDBusInterface constructor which does > introspection and > the init method. > > It should be fine to do blocking calls to kded, but given we don't need > to, we may as well avoid them. > > > Diffs > ----- > > libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 > libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 > > Diff: https://git.reviewboard.kde.org/r/127382/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
