> On March 8, 2016, 5:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop > file which is reverse domain name dot binaryname. How the desktop file which > launched the application is called, doesn't really matter. > > Hrvoje Senjan wrote: > A misunderstanding ;-) > I'm merely talking about people losing their favourite after upgrading to > 5.6. > > Martin Gräßlin wrote: > Sorry I don't get that. Why should renaming result in losing the favorite? > > Matthias Klumpp wrote: > The favourite apps settings is a list with .desktop filenames which are > shown in the launcher. If you now change the .desktop filename, the launcher > entry will become invalid or vanish, although the actual application is still > there, leading to confused users. > > Martin Gräßlin wrote: > and where is that stored? > > Martin Gräßlin wrote: > btw. that's a pretty big problem. We have thousands of incorrectly named > desktop files. I don't want to write a kconf update script for each of them. > I don't mind spending the time to fix the desktop files, but also adding a > kconf update script is quite some work. > > Matthias Klumpp wrote: > Yeah, it's a massive pain. Ubuntu is duplicating .desktop files for that > reason and hiding the new name (so the app doesn't show up twice), so user's > favourites don't break in Unity - which has a whole lot of problems. > GNOME had a .desktop file name mapping once (I think meanwhile they've > just given up completely), but only cared for GNOME apps in there. > > So yes, much pain, hard to solve, really annoying :(
In terms of launchers/favorites, I think adding the reverse domain isn't a problem - the KService storage id lookup function is slightly fuzzy and I think it can handle both versions and resolve them to a KService. Our launcher favorites backend uses it at read-in and then serializes a cleaned version back out. However, the systemsettings->systemsettings5 change might be a problem. In any case the default applet configs should be changed for cleanliness if this gets in. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127308/#review93306 ----------------------------------------------------------- On March 8, 2016, 3:18 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127308/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 3:18 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > ------- > > The desktop file name should include the reverse domain name and must > much the binary. > > > Diffs > ----- > > app/CMakeLists.txt 3fa8dbb52b4cd8fd553c67a768fcd68c51cb83e4 > app/systemsettings.desktop > > Diff: https://git.reviewboard.kde.org/r/127308/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
