> On March 13, 2016, 10:22 a.m., Hugo Pereira Da Costa wrote: > > kstyle/breezeshadowhelper.h, line 172 > > <https://git.reviewboard.kde.org/r/127352/diff/1/?file=449772#file449772line172> > > > > other class members start with "_" rather than "m_" > > please keep it internally consistent (even if not with the rest of e.g. > > kwin)
stupid reviewboard removes "underscore". I meant: 'start with "underscore" rather than "m+underscore"' - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127352/#review93470 ----------------------------------------------------------- On March 12, 2016, 8:28 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127352/ > ----------------------------------------------------------- > > (Updated March 12, 2016, 8:28 a.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > Integrate with Wayland and create a ShadowManager if available. > With the ShadowManager it's possible to create a Shadow for a Surface. > > The Wayland shadow is very similar to the X11 based one, so a lot of > code can be shared. The code is slightly refactored to share the common > code paths to create and destroy the shadow. > > > Diffs > ----- > > kstyle/CMakeLists.txt b2c6dc847fef1c7876a0ac1af9e28f47422b620b > kstyle/breezeshadowhelper.h 0c868d3686eec67e630ce08c36df6b4cf34d7f1c > kstyle/breezeshadowhelper.cpp 1eb1ddc6a154d8865b39936718f6a5d5ef8f7fdd > kstyle/config-breeze.h.cmake ba2b5f64c1ca855c541fd7eb0e919b8f897f481f > > Diff: https://git.reviewboard.kde.org/r/127352/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
