----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93442 -----------------------------------------------------------
Fix it, then Ship it! Like my other review: if we want this approach, the code is fine and good to go. src/plasma/private/packages.cpp (line 46) <https://git.reviewboard.kde.org/r/127345/#comment63705> I'd just go for test.qml or perhaps even autotest.qml - Sebastian Kügler On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127345/ > ----------------------------------------------------------- > > (Updated March 12, 2016, 12:29 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > In an attempt to make it possible for plasmoid to test themselves in the > different shells, provide API to exatract the object that will test the > plasmoid instance. > > > Diffs > ----- > > src/plasma/private/packages.cpp a5ba81a > src/plasmaquick/appletquickitem.h 4f25f5d > src/plasmaquick/appletquickitem.cpp 9242e9e > src/plasmaquick/private/appletquickitem_p.h 9c24734 > > Diff: https://git.reviewboard.kde.org/r/127345/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
