----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93441 -----------------------------------------------------------
Fix it, then Ship it! I'm fine with the approach, but let's first discuss if we the other approach we talked about is feasible, if not, this one should go in. Thanks! shell/main.cpp (line 99) <https://git.reviewboard.kde.org/r/127346/#comment63704> Hm, I think this could use a reference to more documentation shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml (line 8) <https://git.reviewboard.kde.org/r/127346/#comment63703> minor, whitespace shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml (line 10) <https://git.reviewboard.kde.org/r/127346/#comment63702> minor; whitespace shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop (line 2) <https://git.reviewboard.kde.org/r/127346/#comment63701> This is how we ROLL! - Sebastian Kügler On March 12, 2016, 12:43 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127346/ > ----------------------------------------------------------- > > (Updated March 12, 2016, 12:43 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Makes it possible to test how/if a plasmoid behaves correctly on the most > similar environment possible to what the user would find on a production > system. > > * Loads a plasmoid on a panel and the desktop. > * Lets it test his own stuff > * Notifies, when done, if failed. > > There's still more to look into: > * what objects need to be passed, besides the `Plasma::AppletQuickItem`. > * good things to test > * how to test other shells than the desktop shell > > Nevertheless, it looks to me that it's a step forward. Comments welcome. > > > Diffs > ----- > > applets/analog-clock/contents/tests/testmain.qml PRE-CREATION > shell/CMakeLists.txt e553133 > shell/main.cpp d6e3640 > shell/shellmanager.h 17acbc6 > shell/shellmanager.cpp 3c3638f > shell/testcorona.h PRE-CREATION > shell/testcorona.cpp PRE-CREATION > shell/tests/CMakeLists.txt PRE-CREATION > shell/tests/plasma/shells/org.kde.plasmashelltest/contents/layout.js.in > PRE-CREATION > shell/tests/plasma/shells/org.kde.plasmashelltest/contents/loader.qml > PRE-CREATION > shell/tests/plasma/shells/org.kde.plasmashelltest/metadata.desktop > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127346/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
