----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review92995 -----------------------------------------------------------
Turns out pkg_get_variable is available only in cmake 3.4, while minimum requirement is "2.8.12". Can you perhaps change the cmake module to not use pkg_get_variable for now? - Martin Klapetek On Feb. 14, 2016, 1:09 p.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126879/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2016, 1:09 p.m.) > > > Review request for Localization and Translation (l10n), Plasma and John Layt. > > > Repository: plasma-workspace > > > Description > ------- > > Instead of an hardcoded list of translations of country names, look them up > in the iso_3166 domain, provided by iso-codes. The names of countries are > changes to their ISO 3166 versions in iso-codes. > > Look for iso-codes in cmake, but just as indication of it as runtime > dependency. > > > Diffs > ----- > > applets/digital-clock/plugin/CMakeLists.txt > c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 > applets/digital-clock/plugin/timezonesi18n.cpp > 6bb465e68bfba4695c79898d630dec5a7075a058 > cmake/FindIsoCodes.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126879/diff/ > > > Testing > ------- > > With Plasma 5.3 (but this code is the same as in master), the configuration > of timezoned in the digital clock is translated according to iso-codes. > > > Thanks, > > Pino Toscano > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
