----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127226/#review92949 -----------------------------------------------------------
Ship it! src/plasma/private/theme_p.cpp (line 775) <https://git.reviewboard.kde.org/r/127226/#comment63393> ++ I can't think of any situation you'd want to discard the SvgElements cache but not the pixmap cache. - David Edmundson On Feb. 29, 2016, 10:15 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127226/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 10:15 p.m.) > > > Review request for Plasma. > > > Bugs: 359924 > http://bugs.kde.org/show_bug.cgi?id=359924 > > > Repository: plasma-framework > > > Description > ------- > > Changing theme also changes color scheme making the pixmap cache invalid for > monochrome icons. > > > Diffs > ----- > > src/plasma/private/theme_p.cpp cca11f3 > > Diff: https://git.reviewboard.kde.org/r/127226/diff/ > > > Testing > ------- > > This makes the latest IconItem test (themeChange) pass. > > There doesn't seem to be issue with this in plasmashell, because when > changing theme from KCM, the application palette gets changed too (and pixmap > cache is discarded on QEvent::ApplicationPaletteChange). But when only > changing the theme with Plasma::Theme::setThemeName there is no palette > change. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
