> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 253 > > <https://git.reviewboard.kde.org/r/127201/diff/2/?file=445755#file445755line253> > > > > This should be `QSize(32, 32)` as the comment says?
I indented to use a size without exact match. > On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > <https://git.reviewboard.kde.org/r/127201/diff/2/?file=445755#file445755line234> > > > > Why? Actually this check is not so reliable if the icon is not rendered with the same svg backend but it will pass for now. - Xuetian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92843 ----------------------------------------------------------- On Feb. 28, 2016, 1:18 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127201/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2016, 1:18 a.m.) > > > Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, David Rosca, and > Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > Well.. the bug should be obvious: > 1. QString iconPath overrides the iconPath in a higher scope. introduced in > https://git.reviewboard.kde.org/r/126168/ > 2. iconPath not assigned, also introduced in > https://git.reviewboard.kde.org/r/126168/ > 3. svgz -> svg?? introduced in https://git.reviewboard.kde.org/r/126557/ > > > Diffs > ----- > > autotests/data/bug359388/hicolor/22x22/apps/bug359388.svg PRE-CREATION > autotests/data/icons/hicolor/22x22/apps/bug359388.svg 8739af5 > autotests/data/icons/test-theme/apps/22/tst-plasma-framework-test-icon.svg > PRE-CREATION > autotests/data/icons/test-theme/apps/32/tst-plasma-framework-test-icon.svg > PRE-CREATION > autotests/data/icons/test-theme/apps/48/konversation.svg PRE-CREATION > autotests/data/icons/test-theme/index.theme PRE-CREATION > autotests/iconitemtest.h 9fd3063 > autotests/iconitemtest.cpp f675465 > src/declarativeimports/core/iconitem.cpp c65a9a7 > > Diff: https://git.reviewboard.kde.org/r/127201/diff/ > > > Testing > ------- > > tested with qmlscene with Plasma.IconItem. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
