----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127199/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- All autogenerated qtdbus property fetches are synchronous. 1) Don't bother checking the protocol version. If the signals are the same, we may as well try and use the old signals, if it's not - the signals won't match anything anyway so it won't do anything anyway. 2) Replace the blocking RegisteredStatusNotifierItem request with an async variant. CCBUG: 359611 Diffs ----- dataengines/statusnotifieritem/CMakeLists.txt c28312ea4292aaf9a610e5ff8435e08f520c7839 dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 08a8c869f4e1a1445d15f3a4d9fb6fb7e62c3d32 Diff: https://git.reviewboard.kde.org/r/127199/diff/ Testing ------- Ran statusnotifieritem test restarted plasmashell test icon showed up Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
