broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel.
REVISION SUMMARY This removes the custom RubberBand that is painted using QStyle and instead uses a traditional Rectangle. We don't use "Desktop Widget Style" in Plasma anyway. The rubber band now follows the theme's highlight color and has a nice fade animation when it disappears. TEST PLAN Rubber band selection works fine. Repeated quick moving and selecting doesn't make it go nuts, even when the fade out animation is still running. Auto scroll in both popup and as containment is erratic; not sure if this is caused by this patch, however. Using Tilain the rubber band is now white, for example, using Oxygen it's a fainter blue. I did not yet remove the RubberBand cpp stuff as I wanted to get some feedback first before messing up my local repository :) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1028 AFFECTED FILES containments/desktop/package/contents/ui/FolderView.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, hein Cc: plasma-devel
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
