----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/#review92826 -----------------------------------------------------------
No idea about the leak, but the port looks ok (almost) kcms/colors/colorscm.cpp (line 45) <https://git.reviewboard.kde.org/r/127197/#comment63302> #include <KIO/DeleteJob> is sufficient and better. - David Faure On Feb. 27, 2016, 8:27 a.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127197/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2016, 8:27 a.m.) > > > Review request for KDE Frameworks, Plasma, David Edmundson, David Faure, and > Thomas Lübking. > > > Bugs: 357800 > https://bugs.kde.org/show_bug.cgi?id=357800 > > > Repository: plasma-desktop > > > Description > ------- > > Start porting to find leaks on X in radeon driver. > > > Diffs > ----- > > kcms/colors/CMakeLists.txt f02e0eb > kcms/colors/colorscm.h 8e74e8a > kcms/colors/colorscm.cpp f3c4f05 > > Diff: https://git.reviewboard.kde.org/r/127197/diff/ > > > Testing > ------- > > 1. kcmschell5 colors > 2. Apply color scheme > 3. Extremly leak on X > KColorScheme leaks, no? > > > File Attachments > ---------------- > > Screenshot_20160227_102609.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/27/a23bfdad-7465-422e-9cef-25fe7991e795__Screenshot_20160227_102609.png > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
