> On Feb. 23, 2016, 1:38 p.m., David Edmundson wrote: > > Sorry for the massive delay. That's really messed up on our side. > > > > We have a feature freeze next wednesday, it would be great to get this all > > merged by then. I just had a few tiny comments, but I think we're all good > > to go. > > Lars Pontoppidan wrote: > No worries - I just hope we can make it to the release :) > > Lars Pontoppidan wrote: > All issues fixed - how should I proceed from here? > > Luca Beltrame wrote: > Given that you have a Ship It, you should be able to merge your branch to > master and push it (but don't forget the REVIEW: keyword to close this > review) before feature freeze.
I've clicked the "Ship It!" button - I didn't see anything happening? Can I ask you to baby-step guide me on how to do this correctly? I'm on the branch larpon/mediaframe - all ready to merge... Then I do... <insert help here> :) - Lars ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92661 ----------------------------------------------------------- On Feb. 23, 2016, 2:48 p.m., Lars Pontoppidan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126793/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2016, 2:48 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > KF5 version of the (Picture) Frame widget > > > Diffs > ----- > > applets/CMakeLists.txt ed938f8 > applets/mediaframe/CMakeLists.txt PRE-CREATION > applets/mediaframe/Messages.sh PRE-CREATION > applets/mediaframe/package/contents/config/config.qml PRE-CREATION > applets/mediaframe/package/contents/config/main.xml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION > applets/mediaframe/package/contents/ui/main.qml PRE-CREATION > applets/mediaframe/package/metadata.desktop PRE-CREATION > applets/mediaframe/plugin/mediaframe.h PRE-CREATION > applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION > applets/mediaframe/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126793/diff/ > > > Testing > ------- > > kdeplasma-addons builds on Kubuntu 15.10. > > > Thanks, > > Lars Pontoppidan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
