----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126883/#review92668 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Jan. 25, 2016, 2:10 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126883/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 2:10 p.m.) > > > Review request for KDE Frameworks, Plasma and Marco Martin. > > > Repository: kpackage > > > Description > ------- > > This method is intended to replace contentsHash which operates only > on Sha1. In order to support more secure hashing algorithmns and also > to support future developments the new implementation does not hard > code the algorithm but allows to specify it. By that the existing > implementation can just delegate to the new one. > > Another change in the implementation is that the new cryptographicHash > method returns a QByteArray instead of a QString. As only a hex > representation of the hash is returned the conversion to QString is > not necessary. > > Package::contentsHash() is marked as deprecated. > > > Diffs > ----- > > autotests/plasmoidpackagetest.cpp 69f45f57bbec5c0f6d2268869249606c50338765 > src/kpackage/package.h b97b70be42df7d9fd09e3fb4e7b82b00ef970be3 > src/kpackage/package.cpp 4c0f671965d9ed33b9f52b06205bf6ffcda94c8a > > Diff: https://git.reviewboard.kde.org/r/126883/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
