graesslin added a comment.

  I think all your ifdefs are not needeed. Neither are the x11 runtime checks.

INLINE COMMENTS
  imports/activitymanager/sortedactivitiesmodel.cpp:195-217 I don't understand 
why you made this conditional. It should also work on Wayland.
  imports/activitymanager/sortedactivitiesmodel.h:25 Note: the code in 
kwindowsystem goes back to KDE 3 time and is clearly not written by me.
  imports/activitymanager/sortedactivitiesmodel.h:36-43 NET Properties are not 
X11 specific. They are available on all platforms.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1009

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, sebas, davidedmundson, mart, graesslin
Cc: broulik, plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to