----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127115/#review92568 -----------------------------------------------------------
Fix it, then Ship it! src/declarativeimports/core/svgitem.cpp (line 221) <https://git.reviewboard.kde.org/r/127115/#comment63110> if we move m_textureChanged = true into here we can remove it from everywhere else. same for moving update() into scheduleImageUpdate() src/declarativeimports/core/svgitem.cpp (line 227) <https://git.reviewboard.kde.org/r/127115/#comment63111> && newGeometry.isValid() - David Edmundson On Feb. 19, 2016, 3:01 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127115/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 3:01 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Logic is similar to IconItem - rendered image is updated in updatePolish(). > > > Diffs > ----- > > src/declarativeimports/core/svgitem.h 7f9e44c > src/declarativeimports/core/svgitem.cpp 849c85f > > Diff: https://git.reviewboard.kde.org/r/127115/diff/ > > > Testing > ------- > > scheduleImageUpdate() is called wherever m_textureChanged is set to true + > when geometry changes, so it should be identical to old code. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
