----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127112/#review92551 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Feb. 19, 2016, 11:34 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127112/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 11:34 a.m.) > > > Review request for Plasma. > > > Bugs: 359539 > http://bugs.kde.org/show_bug.cgi?id=359539 > > > Repository: plasma-framework > > > Description > ------- > > svgElementsCache may be created on render thread and deleted on main thread, > which will make KSharedConfig crash (it uses per-thread storage). > > > Diffs > ----- > > src/plasma/private/theme_p.h 69a8934 > src/plasma/private/theme_p.cpp 2faced8 > > Diff: https://git.reviewboard.kde.org/r/127112/diff/ > > > Testing > ------- > > I couldn't reproduce the crash, even with QSG_RENDER_LOOP=threaded (on Intel > GPU). > > I think we can't just call reparseConfiguration in discardCache, because > there will be race condititon (reparseConfiguration running on main thread > and config being accessed from render thread). > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
