> On Feb. 16, 2016, 12:09 p.m., David Edmundson wrote: > > Breeze theme version needs bumping as you need the cache to clear. > > > > Are you planning on migrating existing users onto breeze-light? > > Marco Martin wrote: > hmm no, I wanted to have existing users to the new one, if they don't > have weird color schemes they don't notice, otherwise they'll find the whole > desktop on the same color scheme, that i think makes sense (they can still go > back to breeze light) > > If the vdg thinks that it's not an unacceptable default change, we can do > a kconfupdate script > > Andreas Kainz wrote: > how does the monochrome system tray icons look like cause they use also > the colors from system color? > > Marco Martin wrote: > yes, like the k menu > > Andreas Kainz wrote: > Is it possible to 1. change the behavior and 2. do the kde applications > (e.g. dolphin) use also colored monochrome icons? > > Marco Martin wrote: > neither of those, sorry > > Andreas Kainz wrote: > It look like a biger change so how can I test your review? > > Marco Martin wrote: > i want in the long run have qwidget applications to be able to use > colored icons, and thoise are all bady steps for it. > but as you know for qwidget applicatons is all a problem 10 times as hard > > Andreas Kainz wrote: > would it be possible to change also the color of some application > elements like menu, toolbar, ... like you see it here > https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/photo59126345614076845.jpg > Alex from the VDG make it and it would be awesome to integrate something > like "material stuff" in the KCM UI and as you do some stuff here, ... You > know VDG has nice ideas but is always searching for some dev. > > Marco Martin wrote: > that is unrelated.. it would be a change for the Breeze c++ theme and yes > i guess it's possible. > opinion/help of Hugo would be the best for that.
The issue here is that this hands over a large amount of power to the user, if she sets a colour theme that will make some icons tricky to see - then that is what will happen. This doesn't stop us from releasing a "hardcoded" plasma theme - just like the "old Plasma 5.4 theme" still available. The idea here is that IF a user want to swap around color themes, make one herself - then she is most probably capable of looking for the effects of that. - Jens ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127085/#review92431 ----------------------------------------------------------- On Feb. 16, 2016, 12:28 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127085/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 12:28 p.m.) > > > Review request for Plasma and Jens Reuterberg. > > > Repository: plasma-framework > > > Description > ------- > > this makes the default plasma theme follow system colors, there are still > "breeze light" and "breeze dark" themes that behave like the old two > > > Diffs > ----- > > src/desktoptheme/CMakeLists.txt 3087c17 > src/desktoptheme/breeze-light/CMakeLists.txt PRE-CREATION > src/desktoptheme/breeze-light/colors PRE-CREATION > src/desktoptheme/breeze-light/metadata.desktop PRE-CREATION > src/desktoptheme/breeze/CMakeLists.txt 2e28287 > src/desktoptheme/breeze/colors d701701 > > Diff: https://git.reviewboard.kde.org/r/127085/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > color1.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/24f7dc82-1d66-4052-bc6f-af4aab0f15df__color1.png > color2.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/93188d4f-242a-46ac-94a7-182ed600817b__color2.png > color3.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/5151b63c-476b-4ff3-a653-42bf8168836f__color3.png > color4.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/41febde6-795d-437c-b17e-ace92c84ea73__color4.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
