> On Feb. 13, 2016, 11:33 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/appletquickitem.h, line 149 > > <https://git.reviewboard.kde.org/r/127073/diff/1/?file=444218#file444218line149> > > > > This looks binary incompatible. > > > > Also, add Q_DECL_OVERRIDE > > David Rosca wrote: > Looks fine to me (according to policies on techbase), besides this is not > public header.
I'm not installing those headers (probably going to change) but we have to keep them BC anyways. what is doing is reimplmenting an already existing virtual. from the techbase page: "As already explained, you can safely reimplement a virtual function defined in one of the base classes only if it is safe that the programs linked with the prior version call the implementation in the base class rather than the derived one." so "should" be fine? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92328 ----------------------------------------------------------- On Feb. 13, 2016, 11:48 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127073/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2016, 11:48 p.m.) > > > Review request for Plasma. > > > Bugs: 358849 > http://bugs.kde.org/show_bug.cgi?id=358849 > > > Repository: plasma-framework > > > Description > ------- > > Regression from 344dbeb938 > > BUG: 358849 > > > Diffs > ----- > > src/plasmaquick/appletquickitem.h 1e0174a > src/plasmaquick/appletquickitem.cpp 28f1eb5 > src/plasmaquick/private/appletquickitem_p.h 1f99d2f > > Diff: https://git.reviewboard.kde.org/r/127073/diff/ > > > Testing > ------- > > Fixed for example plasmoid from bug. > Would be better if there was a way to fix it without adding another timer, > though. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
