----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127071/#review92366 -----------------------------------------------------------
src/declarativeimports/plasmastyle/ButtonStyle.qml (line 83) <https://git.reviewboard.kde.org/r/127071/#comment62991> Looks bound to implode, I'd rather specify the minimumWith as a property, for every case. - Aleix Pol Gonzalez On Feb. 14, 2016, 12:23 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127071/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2016, 12:23 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Fix text alignment with buttons that sets implicitWidth > to minimumWidth. > > > Diffs > ----- > > src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 > tests/components/button.qml a645537 > > Diff: https://git.reviewboard.kde.org/r/127071/diff/ > > > Testing > ------- > > Direct binding causes binding loop. I'm not really sure on the fix though as > it's quite ugly. > > To reproduce the bug, press "-" in button test. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
