----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127014/#review92185 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Feb. 8, 2016, 6:39 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127014/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 6:39 p.m.) > > > Review request for Plasma and David Edmundson. > > > Bugs: 358719 > https://bugs.kde.org/show_bug.cgi?id=358719 > > > Repository: plasma-workspace > > > Description > ------- > > It is possible that window is destroyed before we start to monitor its event. > > I notice following errors when 358719 is triggered. > QXcbConnection: XCB error: 3 (BadWindow), sequence: 517, resource id: > 113246233, major code: 2 (ChangeWindowAttributes), minor code: 0 > > Try to check if any error happens before we add our event mask to the window > attributes. > > > Diffs > ----- > > xembed-sni-proxy/fdoselectionmanager.h 911df6c > xembed-sni-proxy/fdoselectionmanager.cpp f236e9c > > Diff: https://git.reviewboard.kde.org/r/127014/diff/ > > > Testing > ------- > > 358719 is now fixed. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel