> On Feb. 4, 2016, 6:52 a.m., Luca Beltrame wrote: > > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see > > get in once all the issues have been addressed. Family members are > > depending upon it. ;) > > Lars Pontoppidan wrote: > Hi Luca, I'm working through Kai's list - and have a good few fixes ready > already :) > > I haven't committed anything yet - because I've been a bit unsure if I > should commit them and mark them fixed here - not having fixed all of them > yet. Or if it's more appropriate to wait a make 1 big commit with all of the > fixes? What do you guys usually do? > > Luca Beltrame wrote: > The idea would be to update the patch when you have addressed the issues. > As for the behavior, I've seen both - either incremental fixes, or a big > change. I'd go for incremental IMO (but I'm not a Plasma dev ;) as if the > patch is big it's easier to see what's changed. > > Marco Martin wrote: > yes, you should update the patch here. > Is it in a branch? if so, commit the fixes to the branch to keep it in > sync
Cool. I've updated the diff and kept it in sync with the larpon/mediaframe branch - Lars ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92041 ----------------------------------------------------------- On Feb. 8, 2016, 11:34 a.m., Lars Pontoppidan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126793/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 11:34 a.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > KF5 version of the (Picture) Frame widget > > > Diffs > ----- > > applets/CMakeLists.txt ed938f8 > applets/mediaframe/CMakeLists.txt PRE-CREATION > applets/mediaframe/Messages.sh PRE-CREATION > applets/mediaframe/package/contents/config/config.qml PRE-CREATION > applets/mediaframe/package/contents/config/main.xml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION > applets/mediaframe/package/contents/ui/main.qml PRE-CREATION > applets/mediaframe/package/metadata.desktop PRE-CREATION > applets/mediaframe/plugin/mediaframe.h PRE-CREATION > applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION > applets/mediaframe/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126793/diff/ > > > Testing > ------- > > kdeplasma-addons builds on Kubuntu 15.10. > > > Thanks, > > Lars Pontoppidan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
