> On Feb. 2, 2016, 5:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > <https://git.reviewboard.kde.org/r/126968/diff/1/?file=442552#file442552line29> > > > > backtrace? > > Martin Gräßlin wrote: > I just created a test case for it: https://paste.kde.org/pywvjhtx9 and it > creates this backtrace: https://paste.kde.org/pcxthpmx3 > > It sounds valid to me. It deletes AnimData from JS side and the > AnimationEffect than tries to delete it as well. Why JS is allowed to delete > it, is not clear to me, though > > Thomas Lübking wrote: > The problem is the cancel call from the animationEnded emit - this causes > an erase of what's the present iterator... which is then erased as well. > > We probably need to harden the lib code itr., but the script is of course > wrong: > a) there's no point in cancelling an animation which has just ended > (deleting the property is fine) > b) to know which animation has ended, the animation needs to be tagged in > the metadata > > Martin Gräßlin wrote: > confirmed, it's the cancel, not the delete
-> https://git.reviewboard.kde.org/r/126975/ - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review91965 ----------------------------------------------------------- On Feb. 2, 2016, 9:51 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126968/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 9:51 p.m.) > > > Review request for kwin and Plasma. > > > Bugs: 347863 > https://bugs.kde.org/show_bug.cgi?id=347863 > > > Repository: kwin > > > Description > ------- > > this effect, derived from the Maximize one, will take the place of the manual > window position animation that Plasma tooltip are using. > this should cause less problems as animationg positions on X is very error > prone, plus it's less jarring when the tooltip sizes changes too, since that > gets animated as well (behavior similar to Window7 taskbar tooltips) > look: > https://www.youtube.com/watch?v=sxE23ZgkkpU > slow motion: > https://www.youtube.com/watch?v=jDByfncO568 > > replaces https://git.reviewboard.kde.org/r/126870 > > > Diffs > ----- > > effects/CMakeLists.txt dec50a9 > effects/backgroundcontrast/contrast.cpp 168deb0 > effects/blur/blur.cpp a360f03 > effects/morphingpopups/CMakeLists.txt PRE-CREATION > effects/morphingpopups/package/CMakeLists.txt PRE-CREATION > effects/morphingpopups/package/contents/code/morphingpopups.js PRE-CREATION > effects/morphingpopups/package/metadata.desktop PRE-CREATION > libkwineffects/kwinanimationeffect.h f59eedc > libkwineffects/kwinanimationeffect.cpp 579535b > scripting/scriptedeffect.h 2a77a2f > scripting/scriptedeffect.cpp 7ab065b > > Diff: https://git.reviewboard.kde.org/r/126968/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
