----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/#review91909 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On Feb. 1, 2016, 6:24 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126946/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 6:24 p.m.) > > > Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin. > > > Repository: kdeplasma-addons > > > Description > ------- > > Activity pager settings -> Selecting current desktop -> showDesktop. If > desktop is showed by clicking on widget, it can be restored by clicking on > item in task manager, which lead m_desktopDown to store incorrect state. > > > Diffs > ----- > > applets/activitypager/plugin/activitypager.cpp b991bac > > Diff: https://git.reviewboard.kde.org/r/126946/diff/ > > > Testing > ------- > > Now works correctly, but i'm affraid about checks > #if HAVE_X11 > if (!m_isX11) { > return; > } > why the is performed and even why the hell NETRootInfo is used in that way. > And NETRootInfo::showingDesktop() about be is hell not working function. > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
