> On Jan. 24, 2016, 8:58 p.m., Jonathan Marten wrote: > > Ping anyone? > > Kai Uwe Broulik wrote: > Please if you fixed an issue raised mark is as fixed so the "open issues" > count drops, making it easier to see what has changed. After it's zero and > you already got a "Ship It" (see above, "Fix it", covered behind there's the > "Ship it") feel free to commit.
UX is not an exact science. I might be wrong, and always want to get at least one other opinion. But anyway, ship it. - Heiko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/#review91537 ----------------------------------------------------------- On Jan. 10, 2016, 4:33 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126300/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2016, 4:33 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-desktop > > > Description > ------- > > In Plasma 5 this KCM only lists the names of the available runners, with no > explanation of what they do. In its previous incarnation in KDE4 (the > dropdown list from the runner config button), the descriptions were > displayed. This change restores them. > > > Diffs > ----- > > kcms/runners/kcm.h f1239ee > kcms/runners/kcm.cpp 4af82de > > Diff: https://git.reviewboard.kde.org/r/126300/diff/ > > > Testing > ------- > > Built plasma-desktop with this change, checked appearance of KCM in Breeze, > Oxygen and older styles. > > > File Attachments > ---------------- > > Screenshot before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png > Screenshot after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png > Long lines elided > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png > > > Thanks, > > Jonathan Marten > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
