broulik added a comment. +1
INLINE COMMENTS greeter/greeterapp.cpp:616 perhaps cache the end? for (auto it = m_views.constBegin(), end = m_views.constEnd(); it != end; ++it) powermanagement.cpp:110 I prefer returning a reference for singletons but I guess this way is just consistent with the rest of the APIs there. powermanagement.cpp:149 = default? waylandserver.cpp:205 Be careful with range-for and Qt containers, this detaches. waylandserver.cpp:219 Same here. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, Plasma, broulik Cc: plasma-devel _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
