> On Jan. 13, 2016, 1:48 p.m., Bhushan Shah wrote: > > Fixes: https://bugs.kde.org/show_bug.cgi?id=346815 ? > > David Rosca wrote: > Yes, almost. > > Some applets (eg. color picker) somehow ends not being in `resultsFlow` > children, so their position is not stored in `LayoutManager.positions` array > (see containments/desktop/package/contents/ui/main.qml: 413). I didn't yet > figure out how to fix it.
Disregard my last comment, found the issue. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126731/#review91002 ----------------------------------------------------------- On Jan. 13, 2016, 1:43 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126731/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 1:43 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Fix calculation when positions[row] is undefined. Currently it would > incorrectly return the whole requested area being available without any > further checks. > > > Diffs > ----- > > containments/desktop/package/contents/code/LayoutManager.js fbb879e > > Diff: https://git.reviewboard.kde.org/r/126731/diff/ > > > Testing > ------- > > No longer possible to place applets on top of each others. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
