> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 187 > > <https://git.reviewboard.kde.org/r/126660/diff/1/?file=428735#file428735line187> > > > > This doesn't actually add anything. A better name would IMO be: > > alreadyListed() or something along those lines. > > Andreas Hartmetz wrote: > It also adds it to the list, though.
The point is that it isn't const, and it also has a return value that matters. The name -sort of- conveys both. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 ----------------------------------------------------------- On Jan. 7, 2016, 3:21 p.m., Andreas Hartmetz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126660/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 3:21 p.m.) > > > Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin. > > > Repository: kpackage > > > Description > ------- > > That was a problem in a scenario such as mine, where I have distro > packages and self compiled packages. There were (from the UI) > indistinguishable, duplicate packages in the panel's add applets > UI, in the tray config dialog's "additional items" section, and > probably in other places, too. > Note that requiring to have no duplicate packages in XDG_DATA_DIRS > by removing entries from XGD_DATA_DIRS doesn't fly because /usr > cannot be removed for the non-KF5 things that it brings. > > > Diffs > ----- > > src/kpackage/packageloader.cpp 9f7dd48 > > Diff: https://git.reviewboard.kde.org/r/126660/diff/ > > > Testing > ------- > > Checked for duplicate entries in "add applets" and tray config dialog, no > duplicates anymore. Also no duplicates anymore in KWin effects KCM. > > > Thanks, > > Andreas Hartmetz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
