----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126647/#review90685 -----------------------------------------------------------
The blurred shadow looks wrong. As reference I would use the HIG about images https://techbase.kde.org/Projects/Usability/HIG/Layout/Image "Use a semi-transparent background behind the (was: caption text) controls to preserve contrast for legibility." Perhaps you can adjust dark/bright according the system theme. Alternatively (actually this would have been my first thought) you could place the controls right of the callout text and have the album art instead of the icon. By doing so the callout size and control's position remain as usual. - Heiko Tietze On Jan. 5, 2016, 11:40 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126647/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 11:40 nachm.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Bugs: 352126 > https://bugs.kde.org/show_bug.cgi?id=352126 > > > Repository: plasma-desktop > > > Description > ------- > > This adds media player controls to the tooltip of a media player, using the > already existing mpris dataengine this was pretty straightforward to > implement. > > When album art is available, no window thumbnails will be shown, instead the > album art. There will be a close button on the album art closing the first > window. Multiple windows for a player is uncommon and you can still access > them all by clicking the task manager entry. > > Interestingly enough, Amarok does not expose its album art through MPris. > Also, if it wouldn't crash whilst doing so, you could control Amarok when > it's main window is closed if you have a launcher pinned to your task > manager, basically rendering its tray icon obsolete. > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/Task.qml 2a88886 > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62 > applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126647/diff/ > > > Testing > ------- > > Works with VLC and Audacious, does not work with Dragon as the player > announces itself as "dragonplayer" while its Desktop file says "dragon" > > > File Attachments > ---------------- > > VLC with album art > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/3058dacb-1dfd-464d-a1ec-be90bc9e58a8__mpristaskmanagerreview1.png > Amarok without album art > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/6799d6f6-d505-4f56-9531-3013a3e34ae6__mpristaskmanagerreview2.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
