> On Jan. 5, 2016, 1:56 p.m., David Edmundson wrote:
> > +1 from me
> > 
> > Though AFIAK Kai was doing something related here too?

Yes, but that is only to disable the animation when showing the IconItem after 
being hidden.
This completely disables the animation, which I think would be useful in some 
cases (eg. as Heike mentioned in the Kai's review, for kicker).

I'd like to disable the icon animation for tooltips completely (which I'll post 
in next review).


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126637/#review90647
-----------------------------------------------------------


On Jan. 5, 2016, 12:52 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126637/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 12:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add property animated, that allows to disable cross-fade animation when 
> changing icon (enabled by default).
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 366edf3 
>   src/declarativeimports/core/iconitem.cpp db15d0f 
> 
> Diff: https://git.reviewboard.kde.org/r/126637/diff/
> 
> 
> Testing
> -------
> 
> Setting `animated: false` disables the animation.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to