> On Jan. 1, 2016, 4:48 p.m., Kai Uwe Broulik wrote: > > applets/webbrowser/contents/ui/main.qml, line 58 > > <https://git.reviewboard.kde.org/r/126590/diff/1/?file=428148#file428148line58> > > > > Note plasmoid.configuration.url is a String whereas url is a QUrl. > > Working with URLs, especially comparing them, is unintuitive in QML, in > > doubt use url.toString() and then compare them. > > > > I'm wondering if you need this check at all, as I think the underlying > > QQmlPropertyMap is smart enough to detect non-changes.
You're right it does. qqmlopenmetaobject.cpp:242 and as it compares them as QVariants you shouldn't have any problems comparing QUrl to a string - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126590/#review90397 ----------------------------------------------------------- On Jan. 1, 2016, 4:31 p.m., Mihail Ivchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126590/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2016, 4:31 p.m.) > > > Review request for Plasma. > > > Bugs: 357387 > http://bugs.kde.org/show_bug.cgi?id=357387 > > > Repository: kdeplasma-addons > > > Description > ------- > > Remember last visited url and restore it on startup. > BUG: 357387 > > > Diffs > ----- > > applets/webbrowser/contents/config/main.xml PRE-CREATION > applets/webbrowser/contents/ui/main.qml 3ebf120 > applets/webbrowser/metadata.desktop 222af48 > > Diff: https://git.reviewboard.kde.org/r/126590/diff/ > > > Testing > ------- > > Successfully restored after logout. > Successfully restored after reboot. > Each plasmoid is correctly restored in case there was more than 1 plasmoid. > > > Thanks, > > Mihail Ivchenko > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
