> On Dez. 25, 2015, 5:31 nachm., David Edmundson wrote: > > code looks fine. > > > > Though please do the TODOs before merging as historically we have a have a > > habbit of them not getting done > > Also your StatusNotifierItem leaks - but it proably wants to be the > > lifespan of the application anyway.
The sad face icon is used wrongly *everywhere* so I guess we can use it here, too. About the context menu, I thought I could add a couple of shortcuts there but I guess just having a "Quit" option (unfortunately you cannot tell KStatusNotifierItem *not* to ask before quitting) is sufficient. I was thinking off adding the app icon as overlay but that probably wouldn't work well, at least not with the black KDE logo. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90104 ----------------------------------------------------------- On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126515/ > ----------------------------------------------------------- > > (Updated Dez. 25, 2015, 4:24 nachm.) > > > Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > This adds a new "--passive" option to DrKonqi where it will only show a > StatusNotifierItem rather than bringing up the crash dialog right away. > > This can be useful for auto-restarting shell services (like plasmashell, > krunner, kded) to improve the perceived quality of the product. > > On Windows RT, for example, the guidelines even explicitly say "rather just > dump the user on the home screen than telling him something went wrong, so he > can just quickly start the app again instead of being annoyed by an error > message". On iOS you also just get dropped on the home screen. Windows > desktop shows a "Searching for a solution" dialog which was *the* major > annoyance when something crashed, rather than the actual crash. > > Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc > > > Diffs > ----- > > drkonqi/statusnotifier.cpp PRE-CREATION > drkonqi/statusnotifier.h PRE-CREATION > drkonqi/CMakeLists.txt eaeaad4 > drkonqi/main.cpp 7cbaae7 > > Diff: https://git.reviewboard.kde.org/r/126515/diff/ > > > Testing > ------- > > I crashed plasmashell, it restarted so fast that you didn't even have a black > screen inbetween, just the panel restarting. Afterwards I got a SNI which > opened DrKonqi when tapped. > > The SNI disappears after 1 minute because if you didn't bother to look after > it by then, you probably forgot what you did to cause the crash anyway :) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
