----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121010/#review90090 -----------------------------------------------------------
Ping. (Is a roundtrip to the X Server that bad for the comparatively rare event of getting a notification?) - Kai Uwe Broulik On Nov. 6, 2014, 11:47 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121010/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 11:47 vorm.) > > > Review request for Plasma, KDE Usability and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > This patch improves fullscreen handling in notifications. > > The type of the NotificationPopup is changed to Dialog.Notification because > that's what it's for, I think there's been a bit of a miscommunication about > that (I think there needs to be another layer for the OSD because that one > should be above all..). > The Notification type keeps the window above (sorta fixing Bug 338946 because > the close button now works as expected now) everything but not a fullscreen > window if it's active. This patch checks when a notification arrives whether > the active window is fullscreen (concealing the notification) and adds it to > the history. To indicate that you missed notifications while you were > fullscreen, the icon glows blue (until you interact with a notification or > open the plasmoid). > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationIcon.qml 1449c19 > applets/notifications/package/contents/ui/NotificationPopup.qml 212f1e6 > applets/notifications/package/contents/ui/Notifications.qml acdccdd > applets/notifications/package/contents/ui/main.qml 3c2fa13 > applets/notifications/plugin/notificationshelper.h af8f6fa > applets/notifications/plugin/notificationshelper.cpp 425f0d6 > > Diff: https://git.reviewboard.kde.org/r/121010/diff/ > > > Testing > ------- > > Fullscreened my IDE, "sleep 2; knotificationdbustest", waited, > unfullscreened, icon was blue and the history a few notifications in it. > > > File Attachments > ---------------- > > Pending notification in tray > > https://git.reviewboard.kde.org/media/uploaded/files/2014/11/06/3f2141b2-1452-4e5c-8b00-782c571ad34b__notificationpendingthing.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
