> On Dez. 22, 2015, 9:58 nachm., Kai Uwe Broulik wrote: > > I suppose this is obsolete now. > > David Edmundson wrote: > I don't think it is. > The other patch was about removing a silly timer before loading a pixmap, > however it still always has the fade when changing source. > > Mark Gaiser wrote: > Is that a bad thing, fade[1] when changing sources? > If the fade (when changing sources) is very fast then it might actually > look better to have that instead of jumping from one image to another. > > Just my 5 cents :) > > [1] i suppose you mean crossfade? Fading out the old image fading in the > new one.
this patch is about not crossfading when the icon was previously hidden like when a different tooltip opens because there the old icon showing up briefly is just confusing - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review89951 ----------------------------------------------------------- On März 14, 2015, 2:53 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122859/ > ----------------------------------------------------------- > > (Updated März 14, 2015, 2:53 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > We have a lot of reusable singletons that are just hidden when unneeded > (tooltip, osd). IconItem, however, will always fade from the previous state, > even if the previous action happened minutes ago. > > This patch makes it track its visibility and skip the fade-and-wait dance > when it just became visible. It also removes a visible false call in the > tooltip which I didn't know what it was for. (With it in place, the IconItem > always becomes visible when moving between tooltip areas, breaking the > animation altogether). > > @Eike: Could you check whether this makes it more viable for Kicker? > > > Diffs > ----- > > src/declarativeimports/core/iconitem.h 3ef0306 > src/declarativeimports/core/iconitem.cpp d653bf3 > src/declarativeimports/core/tooltip.cpp 40e0af5 > > Diff: https://git.reviewboard.kde.org/r/122859/diff/ > > > Testing > ------- > > Moving between tray icons - icon fades, moving reaaaally rapidly causes it > not to load any icon until you halt (dunno if that happened before but > doesn't seem too bad) > Hovering tray icon, leaving, waiting, hovering another one - icon does not > fade, is there right away > > There is an issue with the OSD where it would not fade at all anymore when > changing states (eg. change volume, then screen brightness), only on the > first invocation, hence the "WIP" badge. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
