> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. > > David Edmundson wrote: > at which point can you cherry-pick it to the 5.5 branch too please? and > close that bug report. > > David Rosca wrote: > This is plasma-framework. But it can also be fixed in plasma-workspace > with checking the desktp immutability before adding the applet, if it's worth > it? > > Kai Uwe Broulik wrote: > executeSetupPlasmoidScript should perhaps check for plugininfo validity > > David Rosca wrote: > It does, but the applet is null, so ` applet->pluginInfo().isValid() ` > crashes.
oh, you're right. Both are released every month so no different. I just saw "master" and didn't think properly. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126449/#review89825 ----------------------------------------------------------- On Dec. 21, 2015, 2:01 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126449/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 2:01 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > ContainmentPrivate::createApplet may return null pointer (eg. when desktop is > immutable), so check the pointer before emitting appletCreated. > > > Diffs > ----- > > src/plasma/containment.cpp 512cdc4 > > Diff: https://git.reviewboard.kde.org/r/126449/diff/ > > > Testing > ------- > > Fixes crash when pasting to desktop with locked widgets. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
