> On Dec. 18, 2015, 3:35 p.m., Kai Uwe Broulik wrote: > > i'm wondering whether those are still needed
Well, it's still being called. +1 on the patch, it can be further fixed later. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126417/#review89713 ----------------------------------------------------------- On Dec. 18, 2015, 3:20 p.m., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126417/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 3:20 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > my Qt won't cast char* to QString, so explicitly use QStringLiteral here. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp > 614b793fa724e7be0fb2dd8151374303fcc6ec18 > > Diff: https://git.reviewboard.kde.org/r/126417/diff/ > > > Testing > ------- > > Windows. > > > Thanks, > > Patrick Spendrin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel