> On Dec. 15, 2015, 1:03 a.m., Martin Klapetek wrote: > > I quite disagree with this change; by default my Clipboard applet > > can barely fit 5 entries[1], making the minimum height any smaller > > does not seem like an improvement. > > > > [1] http://paste.opensuse.org/view/raw/2bea1130 > > David Edmundson wrote: > yes that's a problem, but it's independent of this. > > Anything in the systray effectively ignores the size hint in the applet > itself and is sys-tray sized. > > This is only going to affect when it's standalone on the desktop.
this change will size the minimum height when you use it as a plasmoid on the desktop not the minimum height for the drop down panel window and for the desktop plasmoid it is an improvement cause you can use the same size as for the panel (if you like) - andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126356/#review89512 ----------------------------------------------------------- On Dec. 15, 2015, 12:24 a.m., andreas kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126356/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 12:24 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > if you use clipboard on the desktop the minimum window height is heigher than > you use clipboard from the panel (drop down window). As the user can define > the width and height for the desktop plasmoid the minimum allowed height > should be at least the same than the drop down window in the panel. so I > change the minimumHeig to 16. > > > Diffs > ----- > > applets/clipboard/contents/ui/clipboard.qml 97230c1 > > Diff: https://git.reviewboard.kde.org/r/126356/diff/ > > > Testing > ------- > > > Thanks, > > andreas kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
