----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89458 -----------------------------------------------------------
Ship it! src/plasma/scripting/scriptengine.cpp (line 89) <https://git.reviewboard.kde.org/r/126320/#comment61223> readStringList() is static so KPluginMetaData:: is probably the better way to call it - Alex Richardson On Dec. 11, 2015, 6:48 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126320/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 6:48 p.m.) > > > Review request for KDE Frameworks, Plasma and Alex Richardson. > > > Repository: plasma-framework > > > Description > ------- > > plasma-scriptengine.desktop defines the property "X-Plasma-ComponentTypes" > as Type=QStringList. When reading it using KPluginMetaData::value(..) it > expects a QString back. This used to work but regressed in kcoreaddons in > commit cfd18cf09b559a050fd6a2680ad4e71eeb950383. Now I'm not sure if calling > KPluginMetaData::value(..) on a property that is known to be a stringlist > should actually return a QString (Alex?), but making it read the property > as a stringlist works and is correct and also fixes Plasma startup for me. > > > Diffs > ----- > > src/plasma/scripting/scriptengine.cpp 1b132de > > Diff: https://git.reviewboard.kde.org/r/126320/diff/ > > > Testing > ------- > > Plasma would get stuck on startup, now I can run Plasma again. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
