> On Дек. 13, 2015, 3:26 след обяд, David Edmundson wrote: > > shell/panelview.cpp, line 941 > > <https://git.reviewboard.kde.org/r/126331/diff/1/?file=421933#file421933line941> > > > > why is this change here?
Update diff, this wan't my fix. It's diff head and branch 5.5.0, i don't see it - ignore it. > On Дек. 13, 2015, 3:26 след обяд, David Edmundson wrote: > > shell/panelview.cpp, line 763 > > <https://git.reviewboard.kde.org/r/126331/diff/1/?file=421933#file421933line763> > > > > this is basically the same as the line as you just added above? (but > > using the right position?) > > > > we certainly don't need both. Basically - yes, but not position of redirected event. On Дек. 13, 2015, 3:26 след обяд, Anthony Fieroni wrote: > > If we just revert that last commit in here (which is basically what this > > change is doing) we go back to reintroducing that bug. > > > > I'll merge this before 5.5.1 if we don't have anything else, but I'd rather > > we had both things fixed properly not just bouncing round between having 2 > > different bugs. > > David Edmundson wrote: > oh, you're the same author as: https://git.reviewboard.kde.org/r/126175/ > > Does this patch fix the issue you're trying to fix there? I hope so :) - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126331/#review89412 ----------------------------------------------------------- On Дек. 13, 2015, 4:08 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126331/ > ----------------------------------------------------------- > > (Updated Дек. 13, 2015, 4:08 след обяд) > > > Review request for Plasma and David Edmundson. > > > Bugs: 354651 > https://bugs.kde.org/show_bug.cgi?id=354651 > > > Repository: plasma-workspace > > > Description > ------- > > Last patch has a reggression due to QtQuick issue (only on Xcb): > QEvent::Leave is triggered after QEvent::MouseButtonPress Qt::LeftButton > > > Diffs > ----- > > shell/panelview.cpp 063343d > > Diff: https://git.reviewboard.kde.org/r/126331/diff/ > > > Testing > ------- > > This QtQuick (Xcb) issue (on Wayland works fine) can be found and on Comic > Strip ('show arrows on mouse over' in settings) every first click on arrow is > ignored. I'm not familiar with Qt, if this bug is fixed or Qt devs must be > noticed for this behavior. During patch testing i found other bug, when drag > an item from task manager and drop in the desktop, on desktop is created a > shortcut, but this works only when widgets are unlocked, if they are locked > drop cause a crash, a backtrace present. > > > File Attachments > ---------------- > > plasmashell-20151213-132332.kcrash.txt > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/13/3720870f-3827-41c3-b522-1a2ac5a5611a__plasmashell-20151213-132332.kcrash.txt > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
