----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126207/#review88973 -----------------------------------------------------------
On the other hand, if PlasmaCore.Dialog respected Layout.preferredWidth/Layout.preferredHeight we could remove all of this (except the initial setting for restoring a width)? - Kai Uwe Broulik On Nov. 30, 2015, 5:56 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126207/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 5:56 nachm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > We must not break the binding on the dialog's size, otherwise changing the > preferredWidth/height of a dialog won't affect it. > > > Diffs > ----- > > desktoppackage/contents/applet/CompactApplet.qml b5bbc70 > > Diff: https://git.reviewboard.kde.org/r/126207/diff/ > > > Testing > ------- > > I wasted hours on finding out why User Manager dialog sizing was broken, > re-writing it several times /o\ > > Changing Layout.preferredHeight changes the dialog size, > Layout.minimumHeight/Layout.maximumHeight constraints still work. Didn't > notice breakage with other applets. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
