> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?.
it should add it, it depends also what are the colors used, as in those icons the monochrome dark color is #4d4d4d, would need the parameters --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with the TextColor class. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 ----------------------------------------------------------- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > ------- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > ----- > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
