> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!
> 
> David Rosca wrote:
>     Hmm, it no longer works because the tooltip size is not bound by the 
> available screen size.
>     So it needs fix in plasma-framework first.
> 
> Marco Martin wrote:
>     hmm, can you explain what the problem in tooltip management is?
> 
> Eike Hein wrote:
>     I tested the patch before I gave the Ship It!, and it worked just fine 
> for me with latest plasma-framework. The Tooltip dialog docked at the screen 
> edges left and right and the contents scrolled.

For some reason, it doesn't work for me (full kdesrc-build today) without

    width: Math.min(Screen.availableDesktopWidth, Math.max(windowRow.width, 
appLabelRow.width)  + _s) 
    
eg. the contentItem.width == viewport.width even after the tooltip doesn't fit 
on screen.

Ok, so I'll commit it and then try to debug my local issue.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
-----------------------------------------------------------


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> -------
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to