> On Nov. 25, 2015, 1:01 p.m., Eike Hein wrote: > > Ship It! > > Eike Hein wrote: > Please commit the patch with GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set to > Fabian. > > David Rosca wrote: > Is this enough, or do you mean anything else? > > git commmit --author="Fabian Vogt <fab...@ritter-vogt.de>"
^ That's fine (the env variables are an alternative). - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126162/#review88793 ----------------------------------------------------------- On Nov. 24, 2015, 10:15 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126162/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 10:15 p.m.) > > > Review request for Plasma. > > > Bugs: 346348 > https://bugs.kde.org/show_bug.cgi?id=346348 > > > Repository: plasma-desktop > > > Description > ------- > > This is basically patch by Fabian Vogt from the bugreport. > But it is still not fixed, so I opened the RR myself. > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/126162/diff/ > > > Testing > ------- > > Bug is now fixed, I cannot see any side-effects. > > Reliable way to reproduce bug: > > 1. Set some launcher to always show > 2. Make sure the app from step 1. is not running (so you have the launcher in > taskmanager without running app) > 3. Mouse over the launcher from step 1., let the tooltip show and then move > mouse out to hide it. > 4. Mouse over some other taskmanager entry that is for running application > 5. Tooltip is shown without labels > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
