----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126163/#review88797 -----------------------------------------------------------
Ship it! desktoppackage/contents/explorer/WidgetExplorer.qml (line 355) <https://git.reviewboard.kde.org/r/126163/#comment60864> reason for this? - Marco Martin On Nov. 24, 2015, 11:46 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126163/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 11:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Widget Explorer takes quite a while to open. Especially now that we load > basically double the number of items (two columns) and significantly more > complex SVGs. This patch uses a couple of tricks to make it feel a lot faster: > - Create context menu items on demand > - Set the model for the list after a slight delay > - Some minor cleanups > > By setting the model later we let the dialog slide in first (KWin does the > animation anyway so it won't block) and then nicely fade in the view once we > have loaded it. > > I have noticed that the applet item model which gets the decoration role from > the applet package can take quite a while blocking the explorer. It might > also be worth investigating whether we should keep the WidgetExplorer around > when it has been opened once (I mean the model, not the QML view) so we save > creating the model everytime we open it again. > > > Diffs > ----- > > desktoppackage/contents/explorer/WidgetExplorer.qml 911d9c9 > > Diff: https://git.reviewboard.kde.org/r/126163/diff/ > > > Testing > ------- > > Feels a lot quicker now. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
