> On Nov. 23, 2015, 10:59 vorm., Martin Gräßlin wrote: > > and what if krunner fails? That's a rhethorical question. I don't think > > that we need a fallback to go to krunner. If it's broken it's broken. Maybe > > show a dialog that it's broken (compare KWin tabbox/tabboxhandler.cpp line > > 289)
@Marco: Do look and feel packages have a fall back? If so, it should be fine, given Breeze will always provide a User Switcher. Thinking of heavily customized KDE installs like SuSE (in case they forgot to adjust/add it to theirs). Also, the default UserSwitcher.qml was present but broken (contained a "1") so could be that the distro-specific copies have that too breaking the fallback (if any)? - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126143/#review88712 ----------------------------------------------------------- On Nov. 23, 2015, 9:26 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126143/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 9:26 vorm.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > In case the UserSwitcher.qml file is missing or broken, let's fall back to > use KRunner's session runner. > > > Diffs > ----- > > ksmserver/server.cpp 9477e54 > ksmserver/switchuserdialog.cpp 26d6710 > > Diff: https://git.reviewboard.kde.org/r/126143/diff/ > > > Testing > ------- > > Broke my UserSwitcher.qml file, got KRunner instead. > Fixed it, got the proper QML UI again. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
